mean to inst field names, part I#704
Merged
Merged
Conversation
42 tasks
DusanJovic-NOAA
approved these changes
Sep 28, 2023
junwang-noaa
approved these changes
Sep 28, 2023
Collaborator
|
@DeniseWorthen testing is finished on ufs-wm PR #1925. @jkbk2004 we have the approvals needed, can you please go ahead to merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For fields imported to FV3atm from CICE6 and CMEPS, changes the field name alias used by FV3atm by removing the 'mean' prefix. Also renames the fields being exported by FV3atm as
mean_prec_rate,mean_fprec_rateandmean_prec_rate_convto beinginstfields in each case. The values of these fields used to fill the export state are unchanged.This is the first part of a two part commit sequence to change field names from mean->inst. This first commit will not change baselines.
Issue(s) addressed
Testing
Incremental testing has been done comparing this feature branch against a baseline created using the two dependent PRs on Hera. All baselines were B4B.
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)